Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform): Unify python and android icons #12637

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(platform): Unify python and android icons #12637

merged 1 commit into from
Feb 10, 2025

Conversation

chargome
Copy link
Member

closes #11176

Temporary fix until we have the according icons:

@chargome chargome requested a review from a-hariti February 10, 2025 13:35
@chargome chargome self-assigned this Feb 10, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:47pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 1:47pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Feb 10, 2025 1:47pm

@codecov Codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 8.88kB (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.71MB -2.85kB (-0.03%) ⬇️
sentry-docs-client-array-push 9.38MB -6.04kB (-0.06%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 968.3kB -0.0%
9523.js -3 bytes 944.51kB -0.0%
../app/[[...path]]/page.js -160 bytes 529.49kB -0.03%
../app/[[...path]]/page.js.nft.json -33 bytes 376.95kB -0.01%
../app/platform-redirect/page.js.nft.json -33 bytes 376.87kB -0.01%
../app/sitemap.xml/route.js.nft.json -33 bytes 374.84kB -0.01%
6635.js (New) 215.12kB 215.12kB 100.0% 🚀
2065.js -48 bytes 81.4kB -0.06%
../app/platform-redirect/page.js -160 bytes 30.67kB -0.52%
../../static/media/python.*.svg (Deleted) -787 bytes 0 bytes -100.0% 🗑️
../../static/media/android.*.svg (Deleted) -948 bytes 0 bytes -100.0% 🗑️
5443.js (Deleted) -215.75kB 0 bytes -100.0% 🗑️

Files in 2065.js:

  • ./src/components/platformIcon.tsx → Total Size: 35.19kB

  • ./src/components/platformIcon.tsx → Total Size: 35.19kB

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] -160 bytes 3.08MB -0.01%
/platform-redirect -160 bytes 2.58MB -0.01%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.95kB -0.0%
static/css/*.css -6.82kB 16.09kB -29.75%
static/css/*.css -1.66kB 4.88kB -25.32%
static/css/*.css 8.47kB 17.18kB 97.31% ⚠️
static/chunks/7801-*.js -3 bytes 391.02kB -0.0%
server/app/_not-*.js -1.3kB 250.78kB -0.52%
server/app/[[...path]]/page_client-*.js -1.3kB 250.74kB -0.52%
server/app/platform-*.js -1.2kB 236.17kB -0.51%
static/chunks/4719-*.js (New) 140.89kB 140.89kB 100.0% 🚀
static/chunks/app/[[...path]]/page-*.js -80 bytes 72.45kB -0.11%
static/chunks/818-*.js -24 bytes 41.48kB -0.06%
static/chunks/app/platform-*.js -80 bytes 12.81kB -0.62%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
/static/media/python.*.svg (Deleted) -787 bytes 0 bytes -100.0% 🗑️
/static/media/android.*.svg (Deleted) -948 bytes 0 bytes -100.0% 🗑️
static/7O5FUl7KngUsnw_UYsD0f/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/7O5FUl7KngUsnw_UYsD0f/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/chunks/2920-*.js (Deleted) -141.21kB 0 bytes -100.0% 🗑️
static/MIzEIMJKw9ddobptCVecJ/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/MIzEIMJKw9ddobptCVecJ/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/818-*.js:

  • ./src/components/platformIcon.tsx → Total Size: 35.27kB

@chargome chargome merged commit 24b3e3b into master Feb 10, 2025
13 checks passed
@chargome chargome deleted the cg/fix-icon-mismatch branch February 10, 2025 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-hariti a-hariti a-hariti approved these changes

Assignees

@chargome chargome

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon missmatch
2 participants
@chargome @a-hariti